Skip to content

bpo-18799: Resurrect test_404.#11196

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
vajrasky:bpo-18799
Dec 17, 2018
Merged

bpo-18799: Resurrect test_404.#11196
serhiy-storchaka merged 1 commit into
python:masterfrom
vajrasky:bpo-18799

Conversation

@vajrasky

@vajrasky vajrasky commented Dec 17, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

the-knights-who-say-ni commented Dec 17, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Dec 17, 2018
@serhiy-storchaka
serhiy-storchaka dismissed their stale review December 17, 2018 14:12

Test hangs locally.

serhiy-storchaka
serhiy-storchaka approved these changes Dec 17, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, all correct. When apply changes correctly, the test is passed.

Let try this on builtbots.

@serhiy-storchaka
serhiy-storchaka merged commit fae9587 into python:master Dec 17, 2018
@miss-islington

miss-islington commented Dec 19, 2018

Copy link
Copy Markdown
Contributor

Thanks @vajrasky for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Dec 19, 2018

Copy link
Copy Markdown

GH-11233 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 19, 2018
@vajrasky @miss-islington
bpo-18799: Resurrect test_404 in test_xmlrpc. (pythonGH-11196)
6815021 
(cherry picked from commit fae9587)

Co-authored-by: Vajrasky Kok <sky.kok@speaklikeaking.com>
@serhiy-storchaka

serhiy-storchaka commented Dec 19, 2018

Copy link
Copy Markdown
Member

I know that @vajrasky signed the CLA a long time ago.

miss-islington added a commit that referenced this pull request Dec 19, 2018
@miss-islington @vajrasky
bpo-18799: Resurrect test_404 in test_xmlrpc. (GH-11196)
9e1c7ed 
(cherry picked from commit fae9587)

Co-authored-by: Vajrasky Kok <sky.kok@speaklikeaking.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vajrasky @the-knights-who-say-ni @miss-islington @bedevere-bot @serhiy-storchaka @arjunaskykok